[PATCH] D22162: [libcxx] [test] Mark bucket_count() equality assertions as nonportable.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 8 12:28:44 PDT 2016


STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

Mark bucket_count() equality assertions as nonportable.

There's nothing in the Standard preventing an unordered container from always having a bucket count of at least 1000, or whatever. Any assertions for exact equality are nonportable and should be marked as such.

http://reviews.llvm.org/D22162

Files:
  test/std/containers/unord/unord.map/bucket_count.pass.cpp
  test/std/containers/unord/unord.map/rehash.pass.cpp
  test/std/containers/unord/unord.map/reserve.pass.cpp
  test/std/containers/unord/unord.map/swap_member.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/allocator.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/assign_copy.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/assign_move.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/copy.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/copy_alloc.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/default.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/init_size.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/init_size_hash.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/init_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/init_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/move.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/move_alloc.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/range_size.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/range_size_hash.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/range_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/range_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/size.fail.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/size.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/size_hash.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/size_hash_equal.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.map/unord.map.swap/swap_non_member.pass.cpp
  test/std/containers/unord/unord.multimap/bucket_count.pass.cpp
  test/std/containers/unord/unord.multimap/iterators.fail.cpp
  test/std/containers/unord/unord.multimap/local_iterators.fail.cpp
  test/std/containers/unord/unord.multimap/rehash.pass.cpp
  test/std/containers/unord/unord.multimap/reserve.pass.cpp
  test/std/containers/unord/unord.multimap/swap_member.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/allocator.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/assign_copy.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/assign_move.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/copy.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/copy_alloc.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/default.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init_size.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init_size_hash.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/move.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/move_alloc.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/size.fail.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/size.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/size_hash.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/size_hash_equal.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.swap/swap_non_member.pass.cpp
  test/std/containers/unord/unord.multiset/bucket_count.pass.cpp
  test/std/containers/unord/unord.multiset/iterators.fail.cpp
  test/std/containers/unord/unord.multiset/local_iterators.fail.cpp
  test/std/containers/unord/unord.multiset/rehash.pass.cpp
  test/std/containers/unord/unord.multiset/reserve.pass.cpp
  test/std/containers/unord/unord.multiset/swap_member.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/allocator.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/assign_copy.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/assign_move.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/copy.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/copy_alloc.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/default.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/init_size.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/init_size_hash.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/init_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/init_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/move.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/move_alloc.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/range_size.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/range_size_hash.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/range_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/range_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/size.fail.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/size.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/size_hash.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/size_hash_equal.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.cnstr/size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.multiset/unord.multiset.swap/swap_non_member.pass.cpp
  test/std/containers/unord/unord.set/bucket_count.pass.cpp
  test/std/containers/unord/unord.set/rehash.pass.cpp
  test/std/containers/unord/unord.set/reserve.pass.cpp
  test/std/containers/unord/unord.set/swap_member.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/allocator.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/assign_copy.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/assign_move.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/copy.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/copy_alloc.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/default.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/init_size.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/init_size_hash.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/init_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/init_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/move.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/range_size.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/range_size_hash.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/range_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/range_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/size.fail.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/size.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/size_hash.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/size_hash_equal.pass.cpp
  test/std/containers/unord/unord.set/unord.set.cnstr/size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.set/unord.set.swap/swap_non_member.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22162.63292.patch
Type: text/x-patch
Size: 167121 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160708/7082acf1/attachment-0001.bin>


More information about the cfe-commits mailing list