[PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

Alexander Droste via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 7 10:39:36 PDT 2016


Alexander_Droste updated this revision to Diff 63091.
Alexander_Droste added a comment.

- make static functions free functions
- make static containers local to their corresponding functions
- only assign the buffer type name in case of an error
- fix capitalization and punctuation in error diagnostic
- usage of formatting placeholders instead of concatenation
- move buffer type name variable out of the loop


http://reviews.llvm.org/D21962

Files:
  clang-tidy/misc/CMakeLists.txt
  clang-tidy/misc/MiscTidyModule.cpp
  clang-tidy/misc/MpiTypeMismatchCheck.cpp
  clang-tidy/misc/MpiTypeMismatchCheck.h
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/misc-mpi-type-mismatch.rst
  test/clang-tidy/Inputs/misc-mpi-type-mismatch/mpimock.h
  test/clang-tidy/misc-mpi-type-mismatch.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21962.63091.patch
Type: text/x-patch
Size: 32402 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160707/a9f5f2b6/attachment-0001.bin>


More information about the cfe-commits mailing list