[PATCH] D21814: clang-rename: support multiple renames with one invocation

[Manuel Klimek via cfe-commits]

klimek added a comment.

In http://reviews.llvm.org/D21814#476572, @bkramer wrote:

> In http://reviews.llvm.org/D21814#475322, @klimek wrote:
>
> > I think we really want 2 tools:
> >  a) one that is optimized for oldname->newname renames, and supports the multi-TU case really well
> >  b) one that is meant to be integrated with editors and works mainly off of a location in a file
> >
> > I'm a bit torn whether putting those 2 into the same executable is a good idea. Looping in Benjamin for additional ideas.
>
>
> I'm fine with both things living in the same binary. The location thing is just a different way of specifying the symbol name. I fail to see how that's related to this review though.


Well, it's about how much features we want to pack into the same binary; once we basically have multiple tools in one tool, adding more different use cases makes sense, I think.


http://reviews.llvm.org/D21814