[PATCH] D22087: [clang-rename] add basic vim integration

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 7 05:36:32 PDT 2016

alexfh added inline comments.

Comment at: clang-rename/tool/ClangRename.cpp:39
@@ -38,3 +38,2 @@
 #include "llvm/Support/Host.h"
-#include <cstdlib>
 #include <string>
bkramer wrote:
> omtcyf0 wrote:
> > bkramer wrote:
> > > This looks unrelated.
> > Right, but I'm not sure one-line patches are welcome.
> > 
> > Is it not alright to put such into random patches? Otherwise creating one-liner...
> I'd do it on the next change to that file, but I can also include it in the patch this time. I generally dislike having completely unrelated changes in a patch and the unnecessary include here doesn't really hurt anyone.
 > I'm not sure one-line patches are welcome.

Cleanup-only patches are fine.


More information about the cfe-commits mailing list