[PATCH] D21978: [analyzer] Add LocationContext to SymbolMetadata

[Aleksei Sidorin via cfe-commits]

a.sidorin added a comment.

In http://reviews.llvm.org/D21978#476200, @NoQ wrote:

> I also never noticed that the block count gets reset on every stack frame, that's pretty unobvious.


Yes, that was surprising for me too.

> Uhm, and it's already there in SymbolConjured. Anyway, fixing the block count itself seems to be pretty complicated.

> 

> Also, maybe once the ScopeContext thing is ready, we'd be able to omit the block count completely.


Not sure. According to review comments, we may want for ScopeContext to be created for scopes with variables declared only (it seems reasonable). So ScopeContext may cover multiple blocks.


http://reviews.llvm.org/D21978