[PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

[Mehdi AMINI via cfe-commits]

mehdi_amini added inline comments.

================
Comment at: docs/CSI.rst:46
@@ +45,3 @@
+allows the LTO to later elide hooks irrelevant to the tool entirely from the
+program-under-test.
+
----------------
The long thread on llvm-dev went to conclude that LTO should not be needed.

================
Comment at: docs/CSI.rst:62
@@ +61,3 @@
+  and ``-emit-llvm`` to the Clang driver, which produces CSI instrumented
+  object files.
+* During the linking stage for the TIX, add additional arguments
----------------
-emit-llvm should not be required. The user can use -flto but that would be orthogonal to CSI.

================
Comment at: docs/CSI.rst:78
@@ +77,3 @@
+Notice that in the final stage of linking, the tool user also needs to link in
+the static library of the CSI runtime to produce the final TIX.  The runtime
+archive is distributed under the ``build/lib/clang/<VERSION>/lib/<OS>``
----------------
bruening wrote:
> This should not be necessary: as mentioned above, if -fcsi is passed to the link line you should be able to have clang automatically add the static csi library, just like is done for the sanitizers.
This is not clear to me: the sanitizers are auto-linking the clang supplied runtime. Here it seems to be about a user-supplied library.


Repository:
  rL LLVM

http://reviews.llvm.org/D21753