[PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 6 04:20:55 PDT 2016


rmaprath updated this revision to Diff 62844.
rmaprath added a comment.

Addressed review comments from @bcraig:

- Got rid of some of the option name cleanups (done to make them more consistent, but not relevant to the patch)
- Arranged it so that `libc++` vendors can drop in `__external_threading` header to override the default api
  - The default api declares the function prototypes and relies on pthread types - this makes it possible to build+test an externally-threaded libc++ variant with vanilla sources. The implementation of the thread api (in `test/support/external_threads.cpp`) is separate from the library, the two are glued together by `__threading_support`.


http://reviews.llvm.org/D21968

Files:
  CMakeLists.txt
  include/__config
  include/__config_site.in
  include/__threading_support
  lib/CMakeLists.txt
  test/CMakeLists.txt
  test/libcxx/test/config.py
  test/libcxx/thread/thread.condition/thread.condition.condvar/native_handle.pass.cpp
  test/libcxx/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/native_handle.pass.cpp
  test/libcxx/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.recursive/native_handle.pass.cpp
  test/libcxx/thread/thread.threads/thread.thread.class/thread.thread.member/native_handle.pass.cpp
  test/libcxx/thread/thread.threads/thread.thread.class/types.pass.cpp
  test/lit.site.cfg.in
  test/support/external_threads.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21968.62844.patch
Type: text/x-patch
Size: 16384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160706/51f7fe32/attachment-0001.bin>


More information about the cfe-commits mailing list