[PATCH] D15926: Do not print certain warnings when input is a header.

Mehdi AMINI via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 5 11:29:59 PDT 2016


mehdi_amini added inline comments.

================
Comment at: include/clang/Basic/LangOptions.h:131
@@ +130,3 @@
+  /// input is a header file (i.e. -x c-header).
+  bool IsHeaderFile = false;
+
----------------
aaron.ballman wrote:
> Should move the initializer to the constructor (not certain that MSVC 2013 supports this construct, but it's also more consistent).
Interestingly I prefer to have them on the fields themselves (when writing new struct/classes), but I agree that consistency takes precedence when adding a field to an existing class.


http://reviews.llvm.org/D15926





More information about the cfe-commits mailing list