[PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

[Alexander Droste via cfe-commits]

Alexander_Droste updated this revision to Diff 62688.
Alexander_Droste added a comment.

Thanks for the review!

This update should address the requested changes:

- functions and variables are made static if possible
- usage of `ArrayRef<const Type *>` instead of `SmallVector<..> &`
- assignment init instead of braced init
- usage of `tooling::fixit::getText` instead of custom function
- no else after return
- remove superfluous single word comments
- `const auto *` if the deduced type is obvious
- add MPI mock header to `test/clang-tidy/Inputs/misc-mpi-type-mismatch/mpimock.h`
- pass `LangOptions` from the AST matcher result
- return bool in while loop directly instead of assigning true and calling break
- generate the diff with full context (`git diff -U999999 master`)


http://reviews.llvm.org/D21962

Files:
  clang-tidy/misc/CMakeLists.txt
  clang-tidy/misc/MiscTidyModule.cpp
  clang-tidy/misc/MpiTypeMismatchCheck.cpp
  clang-tidy/misc/MpiTypeMismatchCheck.h
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/misc-mpi-type-mismatch.rst
  test/clang-tidy/Inputs/misc-mpi-type-mismatch/mpimock.h
  test/clang-tidy/misc-mpi-type-mismatch.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21962.62688.patch
Type: text/x-patch
Size: 34732 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160704/41affa81/attachment-0001.bin>