[PATCH] D21936: [clang-tidy] UnnecessaryValueParamCheck - only warn for virtual methods

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 4 01:55:50 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG after addressing the comment. Thanks!


================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:234
@@ +233,3 @@
+};
+
+struct PositiveNonVirualMethod {
----------------
Please add a test for an override not explicitly marked "virtual" or "override".


Repository:
  rL LLVM

http://reviews.llvm.org/D21936





More information about the cfe-commits mailing list