[PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

Samuel Antao via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 16:34:57 PDT 2016

sfantao added a comment.

Hi Alexey, thanks for the review!

Comment at: include/clang/Driver/Tool.h:132-140
@@ -131,1 +131,11 @@
                             const char *LinkingOutput) const = 0;
+  /// ConstructJob - Construct jobs to perform the action \p JA,
+  /// writing to the \p Outputs and with \p Inputs, and add the jobs to
+  /// \p C. The default implementation assumes a single output and is expected
+  /// to be overloaded for the tools that support multiple inputs.
+  ///
+  /// \param TCArgs - The argument list for this toolchain, with any
+  /// tool chain specific translations applied.
+  /// \param LinkingOutput - If this output will eventually feed the
+  /// linker, then this is the final output name of the linked image.
+  virtual void ConstructJob(Compilation &C, const JobAction &JA,
ABataev wrote:
> Please, format properly. Remove the name of the function and '-' signs after params
Ok, I was following the format used for the other version of the is function.


More information about the cfe-commits mailing list