[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

Samuel Antao via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 15:56:35 PDT 2016

sfantao added a comment.

Hi Alexey,

Thanks for the review!

Comment at: lib/Driver/Action.cpp:133
@@ +132,3 @@
+/// we assume 'host'.
+std::string Action::getOffloadKindName(OffloadKind Kind) {
+  switch (Kind) {
ABataev wrote:
> 1. Maybe it is enough to return just StringRef, rather than std::string
> 2. This can be made 'static'
True, it can be a `StringRef`. This function is already marked static in its declaration.


More information about the cfe-commits mailing list