[PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

Jake VanAdrighem via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 13:41:12 PDT 2016

jakev added a comment.

In http://reviews.llvm.org/D21823#470516, @xur wrote:

> (1) It seems the original options of -fprofile-instr-generate and -fprofile-instr-use will be kept. Is so, what is the guideline to use these two sets of options.

Sorry I'm not sure I understand what you're asking, but it's my understanding that we would simply detail the lack of interoperability between the existing set of flags and the ones added by this patch.

> Also, we need some documentations for the new user-visible

>  options.

I'm happy to add some info to the Clang UserManual in this patch if everyone is happy with the flag names.

> (2) One difference b/w -fprofile-instr-generate/-fprofile-instr-use and the new options is -fpgo-train={source-cfg | optimizer-cfg} can coexist with -fpgo-apply=<file>. I don't think they work as intended in current implementation. I would suggest to not allow it.

Sure, I've updated the patch to not allow this.



More information about the cfe-commits mailing list