[PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

Samuel Antao via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 13:13:22 PDT 2016

sfantao added a comment.

Hi Alexey,

Thanks for the review!

Comment at: include/clang/Driver/Compilation.h:73
@@ +72,3 @@
+  /// architecture, and device offload kind.
+  struct TCArgsKey {
+    const ToolChain *TC;
ABataev wrote:
> 1. 'final'
> 2. default initializers for fields.
I added the default initializers but that required me to add a Ctor so that initializer lists work when this struct is built.

Comment at: include/clang/Driver/Compilation.h:206
@@ +205,3 @@
+  const llvm::opt::DerivedArgList &
+  getArgsForToolChain(const ToolChain *TC, const char *BoundArch,
+                      Action::OffloadKind DeviceOffloadKind);
ABataev wrote:
> 'const' function?
This one can't be marked const has it potentially changes the cache of translated arguments.


More information about the cfe-commits mailing list