[PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

John Brawn via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 05:21:52 PDT 2016

john.brawn added a comment.

In http://reviews.llvm.org/D21385#471807, @Ilod wrote:

> I gave up after this. I have Pyhton 3.5 64 bits, and was building clang 32-bits on Windows with Visual Studio 2015 Update 2.

python 3 isn't supported when building llvm/clang, according to llvm's CMakeLists.txt.

> If that's all, I suppose it's better to have your limitation to plugin support rather than a full support which will bug if you call a function that accesses a static member.


> (By the way, the previous attempt works fine, it was reverted because of a mingw crash which can be fixed by the patch http://reviews.llvm.org/D18847)


> However, couldn't we enable by default LLVM_EXPORT_SYMBOLS_FOR_PLUGINS on the platforms/compilers which doesn't currently support the plugins? Having plugins only work on custom builds of clang seems to be against the main use of plugins. (If testing is the only problem, I would gladly test it on Windows with mingw, and maybe Mac if needed)

After this patch goes in I plan to email llvm-dev/cfe-dev to see if people think that's a good idea.

> Also, could you add in the documentation (cfe/trunk/docs/ClangPlugins.rst) what are the limitations/setup needed to make an out-of-tree plugin?

Will do.



More information about the cfe-commits mailing list