[PATCH] D14326: ASTImporter: expressions, pt.2

Aleksei Sidorin via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 02:26:06 PDT 2016


a.sidorin updated this revision to Diff 62474.
a.sidorin added a comment.

Fix some issues pointed by Serge Pavlov.
Serge: putting a check of FriendDecls to `IsStructurallyEquivalent()` seems like a good idea for me, but we need some additional changes for it.  `CXXRecodeDecl::getFirstDecl()` is private and `StructuralEquivalenceContext()` is located in an anonymous namespace so we cannot forward-declare it in DeclCXX.h to make it friend. We can move  `StructuralEquivalenceContext()` out of anonymous namespace, however. What do you think?


http://reviews.llvm.org/D14326

Files:
  include/clang/AST/ASTImporter.h
  include/clang/AST/DeclFriend.h
  lib/AST/ASTImporter.cpp
  test/ASTMerge/Inputs/class3.cpp
  test/ASTMerge/Inputs/exprs3.cpp
  test/ASTMerge/class2.cpp
  test/ASTMerge/exprs.cpp
  unittests/AST/ASTImporterTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14326.62474.patch
Type: text/x-patch
Size: 41470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160701/cbeb0f25/attachment-0001.bin>


More information about the cfe-commits mailing list