[PATCH] D18171: [CUDA][OpenMP] Create generic offload action

Samuel Antao via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 30 20:01:12 PDT 2016

sfantao added a comment.

In http://reviews.llvm.org/D18171#471824, @sfantao wrote:

> Hi Alexey,
> Thanks for the review! I addressed your comments in the last diff.
> In http://reviews.llvm.org/D18171#471044, @ABataev wrote:
> > No '\brief's
> When you say  "no \brief" do you mean I am using that where I shouldn't or the other way around. I am only adding that for member functions/vars  that I create, should I do that for member I am modifying too? I noticed two places where I was using that for static functions, I removed \brief in those cases. Let me know if that is what you wanted me to do.
> Thanks again,
> Samuel

Ok, I got you. In my comments the abstract can always be the first sentence, so \brief is not required. I'll remove that as you suggest.



More information about the cfe-commits mailing list