[PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

Chandler Carruth via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 30 19:26:53 PDT 2016

chandlerc added a reviewer: scanon.
chandlerc added a comment.

I'm fine with this change, but we should also get Steve to comment on it, and make sure we have a good way of explaining this to users.

In particular, we probably need some documentation around these fast routines that clearly indicates they should only be used when optimizations such as `-ffast-math` and `-ffinite-math-only` should strip the checks. We want to be careful to only use the optimizable forms when that behavior is appropriate. And auditing the ones you've switched for that is something Steve might be better suited to do...


More information about the cfe-commits mailing list