r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"
Robinson, Paul via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 30 15:52:35 PDT 2016
> -----Original Message-----
> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf Of
> Sean Silva via cfe-commits
> Sent: Tuesday, June 28, 2016 5:29 PM
> To: cfe-commits at lists.llvm.org
> Subject: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"
> Author: silvas
> Date: Tue Jun 28 19:29:23 2016
> New Revision: 274084
> URL: http://llvm.org/viewvc/llvm-project?rev=274084&view=rev
> Revert "[PS4] Tighten up a test (noticed in passing)"
> This reverts commit r269709.
> r262285 changed this deliberately so that the test would not be
> sensitive to which binaries are in the same directory as clang.
> See the commit message of that commit for more background.
Okay, but the point of the test is to match a "file.exe" instead
of just "file". See commentary at the top of the test.
Also "orbis-ld" is a prefix of "orbis-ld.gold" and so matching
just the former doesn't verify we're looking for the right one.
I understand taking out the path part of the check in r262285 but
if you named your test linker "orbis-ld.exe" instead of "orbis-ld"
then the test would pass with r269709, right? If that's all this
is about, please undo this revert and use the standard Windows
file extension for your test linkers.
> Modified: cfe/trunk/test/Driver/ps4-linker-win.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/ps4-linker-
> --- cfe/trunk/test/Driver/ps4-linker-win.c (original)
> +++ cfe/trunk/test/Driver/ps4-linker-win.c Tue Jun 28 19:29:23 2016
> @@ -22,5 +22,5 @@
> // RUN: env "PATH=%T;%PATH%;" %clang -target x86_64-scei-ps4 %s -shared
> // RUN: -fuse-ld=ps4 -### 2>&1 | FileCheck --check-prefix=CHECK-PS4-
> LINKER %s
> -// CHECK-PS4-GOLD: \\orbis-ld.gold.exe"
> -// CHECK-PS4-LINKER: \\orbis-ld.exe"
> +// CHECK-PS4-GOLD: \\orbis-ld.gold
> +// CHECK-PS4-LINKER: \\orbis-ld
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
More information about the cfe-commits