[PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

Carlo Bertolli via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 30 12:30:28 PDT 2016


carlo.bertolli added a comment.

Hi

Yes, the purpose of these patches was to check correctness of code gen for the related clauses when targeting nvptx exclusively.
Since I wrote these tests, the base support changed to generate same code on host and any device type, and it seemed to me that the need for a differentiated regression test was not there any more (happy to be told otherwise).

Of course, there are things that we would like to do a bit different on nvptx, especially for firstprivate, but I have not yet had time to work on this and to reflect this into this regression test. If I do, I would like to update this patch, but it seemed too early to just abandon this.

Thanks and please do let me know what is your viewpoint on this

- Carlo


Repository:
  rL LLVM

http://reviews.llvm.org/D18286





More information about the cfe-commits mailing list