[PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

Chandler Carruth via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 30 11:17:36 PDT 2016

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D21810#471486, @jlebar wrote:

> > But I think this is a reasonable workaround until such an API can be provided.
> Should I take that as an LG, or are we waiting for someone else to approve this?

Lacking a more detailed response from Manuel, yea, I think you should check this in... I wrote most of the toolchain search logic you're turning off so I'm happy to provide an LGTM here. I think this is fine for now, fixes an immediate issue, and can be revisited and improved later easily. So yes, LG.


More information about the cfe-commits mailing list