[PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

[Alexey Bataev via cfe-commits]

ABataev added a comment.

General comment: remove '\brief' tags, they are not required anymore, just '\\\' is enough


================
Comment at: include/clang/Driver/Action.h:94
@@ -93,1 +93,3 @@
 
+  /// \brief Flag that is set to true if this action can be collapsed with
+  /// others actions that depend on it. This is true by default and set to false
----------------
'\brief' tag is not required, remove it.

================
Comment at: lib/Driver/Driver.cpp:2400
@@ +2399,3 @@
+  /// \brief Return true if an assemble action can be collapsed.
+  bool canCollapseAssembleAction() {
+    return TC.useIntegratedAs() && !SaveTemps &&
----------------
bool canCollapseAssembleAction() -> bool canCollapseAssembleAction() const

================
Comment at: lib/Driver/Driver.cpp:2408
@@ +2407,3 @@
+  /// \brief Return true if a preprocessor action can be collapsed.
+  bool canCollapsePreprocessorAction() {
+    return !C.getArgs().hasArg(options::OPT_no_integrated_cpp) &&
----------------
Also can be marked as const

================
Comment at: lib/Driver/Driver.cpp:2416
@@ +2415,3 @@
+  /// be collapsed with it.
+  struct JobActionInfoTy {
+    // \brief The action this info refers to.
----------------
I think this can be marked 'final' and add 'nullptr' as a default initializer for 'JA' field

================
Comment at: lib/Driver/Driver.cpp:2424
@@ +2423,3 @@
+
+  /// \brief Append collapsed offload actions from the give nnumber of elements
+  /// in the action info array.
----------------
Remove '\brief'

================
Comment at: lib/Driver/Driver.cpp:2426
@@ +2425,3 @@
+  /// in the action info array.
+  void appendCollapsedOffloadAction(ActionList &CollapsedOffloadAction,
+                                    ArrayRef<JobActionInfoTy> &ActionInfo,
----------------
I think this function can be marked as 'static', no?

================
Comment at: lib/Driver/Driver.cpp:2435
@@ +2434,3 @@
+
+  /// \brief Functions that attempt to perform the combining. They detect if
+  /// that is legal, and if so they update the inputs \a Inputs and the offload
----------------
remove '\brief'


http://reviews.llvm.org/D21840