[PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

Rong Xu via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 13:49:08 PDT 2016

xur added a comment.

Thanks for doing this. I like the patch in general.  Hers are my minor feedbacks:
(1) It seems the original options of -fprofile-instr-generate and -fprofile-instr-use will be kept. Is so, what is the guideline to use these two sets of options. Also, we need some documentations for the new user-visible
(2) One difference b/w -fprofile-instr-generate/-fprofile-instr-use and the new options is -fpgo-train={source-cfg | optimizer-cfg} can coexist with -fpgo-apply=<file>. I don't think they work as intended in current implementation. I would suggest to not allow it.
(3) I would request a driver option to specify the profile name. While  LLVM_PROFILE_FILE environment variable can do that, a command line option is gonna be useful (at least in our setup).




More information about the cfe-commits mailing list