[PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 07:14:54 PDT 2016

aaron.ballman added a subscriber: aaron.ballman.

Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22
@@ +21,3 @@
+namespace {
+// FIXME: Move this node matcher to ASTMatcher.
+const internal::VariadicDynCastAllOfMatcher<Type, EnumType> enumType;
Can you fix this fixme as a prerequisite to this patch? It should be pretty trivial, and I'd hate for it to get forgotten post-commit.

Comment at: test/clang-tidy/misc-unused-using-decls.cpp:152
@@ -148,1 +151,2 @@
+  int t2 = Blue;
We're now lacking a test that says "Green is unused" like we had before. Can you add another test case to bring back the similar diagnostic?


More information about the cfe-commits mailing list