[PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 28 12:21:26 PDT 2016

klimek added inline comments.

Comment at: unittests/ASTMatchers/ASTMatchersTest.h:77
@@ +76,3 @@
+  // Some tests need rtti/exceptions on.  Use an unknown-unknown triple so we
+  // don't instantiate the full system toolchain.  On Linux, instantiting the
+  // toolchain involves stat'ing large portions of /usr/lib, and this slows down
typo: instantiting

Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83
@@ +80,5 @@
+  //
+  // FIXME: This is a hack to work around the fact that there's no way to do the
+  // equivalent of runToolOnCodeWithArgs without instantiating a full Driver.
+  // We should consider having a function, at least for tests, that invokes cc1.
+  std::vector<std::string> Args = {CompileArg, "-frtti", "-fexceptions",
Couldn't we use -ccc-install-dir to prevent toolchain search?


More information about the cfe-commits mailing list