[PATCH] D21741: Add test for D21736 and D21737.
Vedant Kumar via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 27 09:02:50 PDT 2016
vsk added a comment.
Is the plan to commit this along with http://reviews.llvm.org/D21737?
Comment at: test/Profile/cxx-indirect-call.cpp:3
@@ -2,3 +2,3 @@
-// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exceptions -triple %itanium_abi_triple | FileCheck %s
+// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exceptions -triple x86_64-apple-macosx10.9 | FileCheck %s
> vsk wrote:
> > I don't really understand the significance of `makeItaniumABITriple`. Could you explain why this change is necessary? If it's not, please drop it.
> %itanium_abi_tuple may give any target triple that's not win32 - which includes s390x and other platforms that need zeroext. Since this test assumes __llvm_profile_instrument_target has last parameter without zeroext, it'd break when run on s390x. Hardwiring the target to x86_64 ensures we'll never emit zeroext here.
Ok! Thanks for explaining.
More information about the cfe-commits