[PATCH] D21643: Default to using the Unicode version of Win32 APIs

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 23 08:20:10 PDT 2016

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Sure, this serves as a reminder that you should always convert from UTF-8 to wide in Windows support code. I still think we should always explicitly call the wide variants, and it seems like you agree. Defining these macros is just a way to ensure we don't accidentally regress.

Can you build asan with this change? I suspect it will be sensitive to it because it wraps the win32 API directly rather than going through Support.


More information about the cfe-commits mailing list