[PATCH] D21507: Changes after running check modernize-use-emplace (D20964)

Vedant Kumar via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 23 08:09:33 PDT 2016


vsk added a comment.

In http://reviews.llvm.org/D21507#465444, @Prazek wrote:

> In http://reviews.llvm.org/D21507#464791, @vsk wrote:
>
> > Neat! It would help to upload a git-clang-format'd. Fwiw I only managed to look over the changes in lib/{ARCMigrate,AST,Analysis}.
> >
> > Have you run check-all and the full test-suite?
>
>
> Yep, didn't have any problems with dat


Ok great! This looks good then. I'd wait for one of the clang-tidy devs to give an actual lgtm. It might also be worth sending a "heads-up" email to llvm-dev once it's approved.


Repository:
  rL LLVM

http://reviews.llvm.org/D21507





More information about the cfe-commits mailing list