[PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected<string> instead of empty string to indicate potential error.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 23 07:13:22 PDT 2016

klimek added inline comments.

Comment at: lib/Format/Format.cpp:1395
@@ -1394,2 +1394,3 @@
+// If any replacements in \p Replaces fails to apply, this returns \p Replaces.
 template <typename T>
ioeric wrote:
> klimek wrote:
> > Why would we want to return the same replacements?
> this is just a temp solution to keep the current interfaces of processReplacements and formatReplacements...should I add a FIXME or can I change them in this patch as well? 
Both are good options :) Choose one.


More information about the cfe-commits mailing list