[PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

[John McCall via cfe-commits]

rjmccall added a comment.

Yeah, 2048 is clearly too few.  The other changes aren't necessary; if we're going to try to be that generous, there's a lot of places in the AST that need to be updated.


================
Comment at: lib/CodeGen/CGCleanup.h:61
@@ -60,3 +60,3 @@
 
-    unsigned NumHandlers : 32 - NumCommonBits;
+    unsigned NumHandlers;
   };
----------------
This one seems unnecessary.  29 bits is fine.

================
Comment at: lib/CodeGen/CGCleanup.h:93
@@ -92,3 +92,3 @@
     /// from this index onwards belong to this scope.
-    unsigned FixupDepth : 32 - 18 - NumCommonBits; // currently 12
+    unsigned FixupDepth;
   };
----------------
This should just be pulled out of the BitFields structure and into the EHCleanup class.

================
Comment at: lib/CodeGen/CGCleanup.h:100
@@ -99,3 +99,3 @@
 
-    unsigned NumFilters : 32 - NumCommonBits;
+    unsigned NumFilters;
   };
----------------
This one is also unnecessary.


http://reviews.llvm.org/D21566