[PATCH] D21306: [x86] AVX FP compare builtins should require AVX target feature (PR28112)

Simon Pilgrim via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 21 11:31:04 PDT 2016

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - the compile warning is clear and it could be a problem if we allow undefined values through on pre-AVX targets.

The only other thing we could do is handle these in CGBuiltin and 'accept' 0-7 values through on sse/sse2 targets and assert on other values but I don't see how this would be better.


More information about the cfe-commits mailing list