[PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

Rudy Pons via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 21 11:25:17 PDT 2016

Ilod marked an inline comment as done.

Comment at: test/Driver/cl-options.c:283
@@ -282,3 +282,2 @@
 // RUN:    /nologo \
-// RUN:    /Ob1 \
 // RUN:    /openmp- \
hans wrote:
> You're removing it from the ignored flags here, but I don't see any code change or test for how clang-cl's supposed to handle it. What am I missing?
Removing it from the ignored flags make if fallback to the generic /0 multi-param handling, in MSVCToolchain.cpp TranslateOptArg function.
However I just checked that I forgot to forward the argument from the clang driver to cc1 in ConstructJob. Will add this (and a test for the driver) and submit a new patch.


More information about the cfe-commits mailing list