[PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Jakub StaroĊ„ via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 21 10:29:10 PDT 2016

staronj added inline comments.

Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:132
@@ +131,3 @@
+  // "constructedType"
+  auto HasTypeSameAsConstructed = hasType(hasCanonicalType(
+      ignoringRefsAndConsts(equalsBoundNode("constructedType"))));
Prazek wrote:
> I am aware of LLVM style guide, but I think there is exception for the matchers - they looks much more like a matchers when they starts with lower case. I am not sure if it is not spoken rule, but I don't remember single binded matcher that would start with capital case.
See UnnecessaryValueParamCheck.cpp line 33 or LoopConvertCheck.cpp lines 37-47. They all start with capital letter.


More information about the cfe-commits mailing list