[PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 21 05:19:16 PDT 2016

Anastasia added inline comments.

Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:220
@@ +219,2 @@
+def warn_option_depre_ocl_version : Warning<
+  "Option %0 is deprecated for this OpenCL version">, InGroup<Deprecated>; 
Looks good. If we could output the current OpenCL version as well to match the diagnostic style from http://reviews.llvm.org/D19780, it would be nice. 

Comment at: test/Driver/opencl.cl:32
@@ -14,2 +31,3 @@
+// CHECK-DENORMS-ARE-ZERO: .*clang.* "-cc1" .* "-cl-denorms-are-zero"
 kernel void func(void);
Could you also test the new diagnostic message you are adding please?


More information about the cfe-commits mailing list