[PATCH] D19754: Allow 'nodebug' on local variables

Paul Robinson via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 15 16:35:33 PDT 2016


probinson updated this revision to Diff 60930.
probinson added a comment.

Removed the apparently redundant test for a const local variable.

Yes, I'm back to this after way longer than expected.  I believe, for this patch specifically, the extra const local variable was the only identifiable problem.  There were other issues regarding the overall test, which were partly discussed here and partly in http://reviews.llvm.org/D19567, but those were not specific to this patch.

@dblaikie, I propose that with the 'const' test removed, we allow this patch to proceed (which completes the implementation, something I would dearly like to have done before 3.9 branches) with the promise that I'll come back around to the broader topic of the test file in general as a follow-up.


http://reviews.llvm.org/D19754

Files:
  include/clang/Basic/Attr.td
  include/clang/Basic/AttrDocs.td
  lib/CodeGen/CGDebugInfo.cpp
  test/CodeGenCXX/debug-info-nodebug.cpp
  test/CodeGenObjC/debug-info-nodebug.m
  test/Sema/attr-nodebug.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19754.60930.patch
Type: text/x-patch
Size: 4699 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160615/34eea882/attachment-0001.bin>


More information about the cfe-commits mailing list