[PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

[Renato Golin via cfe-commits]

rengolin added inline comments.

================
Comment at: lib/Basic/Targets.cpp:5709
@@ -5716,3 +5708,3 @@
 
   void getTargetDefines(const LangOptions &Opts,
                         MacroBuilder &Builder) const override {
----------------
We'll have to re-work these parts anyway. When I was looking to do the target parser for aarch64 last year, I realised that there are a lot of weird decisions (like this one), and I'd rather do it slowly and surely, to make sure we do it right.

IIRC, this function was being used as "checkCPU" instead on the ARM target as well, and we made it do what it says in the tin. There are a lot of changed in the ARM world that we can easily translate here.

But not on this patch. :)


Repository:
  rL LLVM

http://reviews.llvm.org/D21277