[PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

[Piotr Padlewski via cfe-commits]

Prazek added inline comments.

================
Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:53
@@ +52,3 @@
+/// matches the given matcher.
+AST_MATCHER_P(QualType, ignoringRefsAndConsts,
+              ast_matchers::internal::Matcher<QualType>, InnerMatcher) {
----------------
{meme, src="instructions_unclear", above="matches were unclear", below="matched matches"}
A little bit too much used word matcher/matches :D



================
Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:132
@@ +131,3 @@
+  // "constructedType"
+  auto HasTypeSameAsConstructed = hasType(hasCanonicalType(
+      ignoringRefsAndConsts(equalsBoundNode("constructedType"))));
----------------
I am aware of LLVM style guide, but I think there is exception for the matchers - they looks much more like a matchers when they starts with lower case. I am not sure if it is not spoken rule, but I don't remember single binded matcher that would start with capital case.


http://reviews.llvm.org/D21303