[PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

Ranjeet Singh via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 13 04:34:50 PDT 2016


rs marked 3 inline comments as done.

================
Comment at: test/CodeGen/builtins-arm.c:203
@@ -188,5 +202,3 @@
 
-void mcrr2(unsigned a, unsigned b) {
-  // CHECK: define void @mcrr2(i32 [[A:%.*]], i32 [[B:%.*]])
-  // CHECK: call void @llvm.arm.mcrr2(i32 15, i32 0, i32 [[A]], i32 [[B]], i32 0)
-  __builtin_arm_mcrr2(15, 0, a, b, 0);
+uint64_t mrrc2() {
+  // CHECK: define i64 @mrrc2()
----------------
rengolin wrote:
> I'm assuming this is a "soon to be documented" move, right?
> 
> It's really hard to review patches with these things changing all the time...
>I'm assuming this is a "soon to be documented" move, right?

Yes I've written the document myself which defines these intrinsics.

>It's really hard to review patches with these things changing all the time...

Sorry, I didn't know these sorts of thing change that often.


http://reviews.llvm.org/D21179





More information about the cfe-commits mailing list