[PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Vedant Kumar via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 9 10:18:46 PDT 2016


vsk added a reviewer: flx.
vsk updated this revision to Diff 60194.
vsk added a comment.

- Fix handling of push_back(X(/* comment */)).
- Don't try to emit a warning when the callee comes from a macro expansion.
- Get rid of a weird/wrong comment about checking for "default constructors".

As a side note, I'd appreciate advice on how to apply this check to the llvm codebase (via some kind of cmake invocation?) and gather numbers.


http://reviews.llvm.org/D21185

Files:
  clang-tidy/performance/CMakeLists.txt
  clang-tidy/performance/EmplaceCheck.cpp
  clang-tidy/performance/EmplaceCheck.h
  clang-tidy/performance/PerformanceTidyModule.cpp
  test/clang-tidy/performance-emplace-into-containers.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21185.60194.patch
Type: text/x-patch
Size: 7683 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160609/97bbdc1f/attachment.bin>


More information about the cfe-commits mailing list