[PATCH] D20933: Preallocate ExplodedNode hash table

Devin Coughlin via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 8 14:50:21 PDT 2016


dcoughlin added a comment.

A 6% speed improvement could be a big win! Do we have a sense of what the expected increased memory cost (as a % of average use over the lifetime of the process) is? My guess is it would be relatively low. I suspect most analyzer users run relatively few concurrent 'clang' processes -- so this might be well worth it.

I do think we should make sure the user can't shoot themselves in the foot by pre-reserving space for an absurdly high maximum step count. We might want to to clamp this reservation to something that is not outrageous even when the maximum step count is huge.


http://reviews.llvm.org/D20933





More information about the cfe-commits mailing list