[PATCH] D21036: Misplaced const-qualification with typedef types

Samuel Benzaquen via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 7 09:58:44 PDT 2016


sbenza added a comment.

In http://reviews.llvm.org/D21036#450935, @aaron.ballman wrote:

> In http://reviews.llvm.org/D21036#450106, @sbenza wrote:
>
> > I think this would be more interesting with macros.
> >  Eg triggering in code like this:
> >
> >   #define FOO(type, op) const type& X = op()
> >   FOO(int*, bar);
>
>
> Sorry, I originally missed this comment.
>
> That might be a reasonable addition to this check, but strikes me as a future enhancement. Are you looking for the patch to cover this case initially, or is it fine for a follow-up?


Yes, a follow up is ok. I was just making sure this is considered.


http://reviews.llvm.org/D21036





More information about the cfe-commits mailing list