[PATCH] D20966: [include-fixer] Add the missing header to the file where the unidentified symbol comes from.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 7 02:41:30 PDT 2016


hokein added inline comments.

================
Comment at: include-fixer/IncludeFixer.cpp:104
@@ -103,3 @@
-    //   class Bar;
-    //   Foo<Bar> foo;
-    //
----------------
bkramer wrote:
> Does this patch do the right thing for the test case in the comment? Otherwise we'll try add includes to system headers all the time, which both wrong and invisible to the user.
No, the patch doesn't handle this case :(. Currently it is hard to figure out this case. For the system headers, we can probably blacklist them? 


http://reviews.llvm.org/D20966





More information about the cfe-commits mailing list