[PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Piotr Padlewski via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 4 01:40:20 PDT 2016


Prazek added a comment.

In http://reviews.llvm.org/D20964#448551, @Eugene.Zelenko wrote:

> In http://reviews.llvm.org/D20964#448525, @Prazek wrote:
>
> > In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote:
> >
> > > I think will be good idea to try this check with LLVM STL too.
> >
> >
> > You mean llvm::SmallVector stuff?
>
>
> No, I meant to build example with -stdlib=libc++, -lc++, -lc++abi. Just to make sure, that hasName() is proper matcher.


I runned it on llvm codebase with libstdc++ and it worked perfectly. I don't think there should be any change with libc++. I will run it only on small with libc++, because it will take too much time to compile whole llvm again.


http://reviews.llvm.org/D20964





More information about the cfe-commits mailing list