[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 3 15:09:54 PDT 2016


alexfh added a comment.

In http://reviews.llvm.org/D20689#443266, @varjujan wrote:

> Yes, I did. The results from running the checker on LLVM are in the attached file. Sadly, I could'nt find any real mistakes but as I wrote in the summary, false positives can still indicate bad naming convention for some variables.
>
> F1991684: result.txt <http://reviews.llvm.org/F1991684>


It looks like the check doesn't meet the quality bar, at least, in its current form. "Bad naming convention" is a very arguable thing and I'm not sure we can claim that the pattern detected by the check is somehow an indication of a bad naming convention.


http://reviews.llvm.org/D20689





More information about the cfe-commits mailing list