[PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 2 18:34:27 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG


================
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:109
@@ -100,1 +108,3 @@
+  // giving an incorrect message, we mark all of them as used.
   for (auto &Context : Contexts) {
+    if (Context.UsingTargetDecls.count(D->getCanonicalDecl()) > 0)
----------------
I suspect that linear search here may be the reason for the poor performance of the check (on a large file it's in top 3 by time spent). This should be addressed separately. Maybe leave a FIXME?


http://reviews.llvm.org/D20909





More information about the cfe-commits mailing list