[PATCH] D20922: [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 2 09:48:36 PDT 2016


STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

Fixes MSVC warning C4459 "declaration of 'x' hides global declaration".

NOTE: As the addition of const is a semantic change, please double-check that the tests are passing. With MSVC I observe that this fixes the compiler warnings, but I still have unrelated runtime failures.

http://reviews.llvm.org/D20922

Files:
  test/std/numerics/complex.number/cases.h
  test/std/numerics/complex.number/complex.ops/complex_divide_complex.pass.cpp
  test/std/numerics/complex.number/complex.ops/complex_times_complex.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/acos.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/asin.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/asinh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/atan.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/atanh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/cos.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/cosh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/exp.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/log.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/log10.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/pow_complex_complex.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/pow_complex_scalar.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/pow_scalar_complex.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/sin.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/sinh.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/sqrt.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/tan.pass.cpp
  test/std/numerics/complex.number/complex.transcendentals/tanh.pass.cpp
  test/std/numerics/complex.number/complex.value.ops/abs.pass.cpp
  test/std/numerics/complex.number/complex.value.ops/arg.pass.cpp
  test/std/numerics/complex.number/complex.value.ops/norm.pass.cpp
  test/std/numerics/complex.number/complex.value.ops/polar.pass.cpp
  test/std/numerics/complex.number/complex.value.ops/proj.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20922.59407.patch
Type: text/x-patch
Size: 75416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160602/1106de71/attachment-0001.bin>


More information about the cfe-commits mailing list