[PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 2 08:22:30 PDT 2016


mclow.lists added a comment.

In general, I'm OK with this - but I'm concerned about that there's not really any provision for the case where `strerror_r` does not exist.

Also, there's no reason to have a thread local static array here, if you're going to immediately copy it into a `std::string`.


http://reviews.llvm.org/D20903





More information about the cfe-commits mailing list