[PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

[Stephen Hines via cfe-commits]

srhines added a comment.

After talking to Richard this afternoon on IRC, we are going with a slightly different plan here. We will create two new triples (renderscript32-*-* and renderscript64-*-*), which are direct subclasses of the general Android ARM32 and ARM64 targets. In this case, we can use all of the existing ABI info we already have built up for these targets (and override longs to be 64-bit on the renderscript32-*-* target). Additionally, the renderscript targets will also set the triple name back to the ARM-related triple, since we can't break compatibility for generating RenderScript code that is expected to embed the ARM triples in the bitcode (mostly ignored, but might be validated).

One thing that didn't come up in the IRC discussion, but we probably still need a LangOpt for RenderScript. There is a coming patch that adds a single attribute (for "kernel"), that has error checking to ensure that it is only used by our RenderScript targets. I assume that the cleanest way to retain that diagnostic (and get the last of these divergent patches in) will be to still key off of a LangOpt. If you think it is preferable to check against a target instead, I can change the code to do that, but I figured this is more consistent with how other attributes work.


http://reviews.llvm.org/D20709