[PATCH] D20389: NVPTX: Add supported CL features

Jan Vesely via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 19:05:24 PDT 2016


jvesely added inline comments.

================
Comment at: test/Misc/nvptx.languageOptsOpenCL.cl:1
@@ +1,2 @@
+// REQUIRES: nvptx-registered-target
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple nvptx-unknown-unknown
----------------
Anastasia wrote:
> Should we check for errors on unsupported extensions for this target too?
I didn't want to do that. Including unsupported extensions in these tests would imply that every OCL extension needs test in 4 places (nvptx, amdgcn, r600, extension-version.cl), possibly more if more targets are added, which seemed excessive.


Repository:
  rL LLVM

http://reviews.llvm.org/D20389





More information about the cfe-commits mailing list