[PATCH] D20887: [libcxx] Allow target flags to affect CMake configuration tests

Saleem Abdulrasool via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 17:52:17 PDT 2016


compnerd requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: CMakeLists.txt:259
@@ +258,3 @@
+add_target_flags_if(LIBCXX_TARGET_TRIPLE "-target ${LIBCXX_TARGET_TRIPLE}")
+add_target_flags_if(LIBCXX_SYSROOT "--sysroot ${LIBCXX_SYSROOT}")
+add_target_flags_if(LIBCXX_GCC_TOOLCHAIN "-gcc-toolchain ${LIBCXX_GCC_TOOLCHAIN}")
----------------
This is missing the `='.  As much as I like the separate arguments, it does cause a difference here :-(.  It should be "--sysroot=${LIBCXX_SYSROOT}".


http://reviews.llvm.org/D20887





More information about the cfe-commits mailing list